Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another round of experiment, with 10/18 cores on ARM/Intel Macs. #1600

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Another round of experiment, with 10/18 cores on ARM/Intel Macs. #1600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions buildkite/bazelci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1840,7 +1840,8 @@ def concurrent_test_jobs(platform):
elif is_mac() and THIS_IS_TESTING:
return "4"
elif is_mac():
return "8"
# TODO(twerth): This is an experiment, remove.
return str(int(multiprocessing.cpu_count()/2))
return "12"


Expand Down Expand Up @@ -2157,8 +2158,7 @@ def execute_bazel_test(
aggregated_flags = [
"--flaky_test_attempts=3",
"--build_tests_only",
# TODO(twerth): Remove after experiment.
# "--local_test_jobs=" + concurrent_test_jobs(platform),
"--local_test_jobs=" + concurrent_test_jobs(platform),
]
# Don't enable remote caching if the user enabled remote execution / caching themselves
# or flaky test monitoring is enabled, as remote caching makes tests look less flaky than
Expand Down Expand Up @@ -2190,8 +2190,7 @@ def execute_bazel_test(
def execute_bazel_coverage(bazel_version, bazel_binary, platform, flags, targets):
aggregated_flags = [
"--build_tests_only",
# TODO(twerth): Remove after experiment.
# "--local_test_jobs=" + concurrent_test_jobs(platform),
"--local_test_jobs=" + concurrent_test_jobs(platform),
]
print_collapsed_group(":bazel: Computing flags for coverage step")
aggregated_flags += compute_flags(
Expand Down