Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional salt to Action #149

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Add optional salt to Action #149

merged 1 commit into from
Aug 11, 2020

Conversation

erikmav
Copy link
Contributor

@erikmav erikmav commented Jul 15, 2020

To allow invalidating bad caches.

@googlebot googlebot added the cla: yes Pull requests whose authors are covered by a CLA with Google. label Jul 15, 2020
@erikmav erikmav changed the title Add optional salt digest to ActionResult Add optional salt digest to Action Jul 15, 2020
@erikmav erikmav changed the title Add optional salt digest to Action Add optional salt to Action Jul 15, 2020
@erikmav erikmav force-pushed the dev/erikmav/actionResultSalt branch 2 times, most recently from 0b01424 to be17725 Compare July 15, 2020 20:08
@erikmav erikmav mentioned this pull request Jul 15, 2020
Closed
@erikmav erikmav force-pushed the dev/erikmav/actionResultSalt branch from be17725 to 0c83c03 Compare July 15, 2020 22:19
@EdSchouten
Copy link
Collaborator

Thanks for working on this, Erik!

@sstriker sstriker merged commit b0a4d4e into bazelbuild:master Aug 11, 2020
mostynb added a commit to mostynb/remote-apis that referenced this pull request Aug 11, 2020
@mostynb
update generated go bindings for MurmurHash3
2c75840 
Followup to bazelbuild#146 which updated the .proto file but forgot to regenerate
the generated go bindings.

Update: and bazelbuild#149 for the Action.salt.
sstriker pushed a commit that referenced this pull request Aug 11, 2020
@mostynb
Update generated go bindings for MurmurHash3 (#153)
e44c723 
Followup to #146 which updated the .proto file but forgot to regenerate
the generated go bindings.

Update: and #149 for the Action.salt.
santigl pushed a commit to santigl/remote-apis that referenced this pull request Aug 26, 2020
Add virtual inputs to command proto. Fixes bazelbuild#149. (bazelbuil…
cc93e30 
…d#150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostynb mostynb mostynb left review comments

@EdSchouten EdSchouten EdSchouten approved these changes

@sstriker sstriker sstriker approved these changes

@bergsieker bergsieker bergsieker approved these changes

@agoulti agoulti Awaiting requested review from agoulti

@buchgr buchgr Awaiting requested review from buchgr

@ola-rozenfeld ola-rozenfeld Awaiting requested review from ola-rozenfeld

Assignees
No one assigned
Labels
cla: yes Pull requests whose authors are covered by a CLA with Google.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erikmav @EdSchouten @sstriker @mostynb @bergsieker @googlebot