Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify WriteRequest.write_offset spec for compressed blobs #193

Merged
merged 9 commits into from
Apr 22, 2021
Merged

Clarify WriteRequest.write_offset spec for compressed blobs #193

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0887c17
Fix incorrect protobuf spec
nodirg Apr 19, 2021
e9fa041
clarify
nodirg Apr 20, 2021
3006bb2
Clarify that WriteRequest.write_offset refers to uncompressed blob
nodirg Apr 20, 2021
35b7bd9
Clarify further
nodirg Apr 20, 2021
9785883
The previous
nodirg Apr 20, 2021
2c0a44e
Ack nonsensical semantics
nodirg Apr 21, 2021
4405d1a
nit
nodirg Apr 21, 2021
99974c2
nit
nodirg Apr 21, 2021
ac23a6c
Remove a promise
nodirg Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions build/bazel/remote/execution/v2/remote_execution.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,11 @@ service ActionCache {
// the uploaded data once uncompressed, and MUST return an
// `INVALID_ARGUMENT` error in the case of mismatch.
//
// Note that when writing compressed blobs, the `WriteRequest.write_offset`
// refers to the offset in the uncompressed form of the blob.
// Note that when writing compressed blobs, the `WriteRequest.write_offset` in
// the initial request refers to the offset in the uncompressed form of the
nodirg marked this conversation as resolved.
Show resolved Hide resolved
// blob. In subsequent requests, `WriteRequest.write_offset` MUST be the sum of
// previous `WriteRequest.write_offset` and the size of the chunk in the
nodirg marked this conversation as resolved.
Show resolved Hide resolved
// previous request.
//
// Uploads of the same data MAY occur concurrently in any form, compressed or
// uncompressed.
Expand Down