Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require that early-return compressed-blobs bytestream uploads set committed_size -1 #213

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Require that early-return compressed-blobs bytestream uploads set committed_size -1 #213

merged 1 commit into from
Feb 23, 2022

Commits on Jan 30, 2022

  1. Require that early-return compressed-blobs bytestream uploads set com… 

    …mitted_size -1

We require that uncompressed bytestream uploads specify committed_size
set to the size of the blob when returning early (if the blob already
exists on the server).

We also require that for compressed bytestream uploads committed_size
refers to the initial write offset plus the number of compressed bytes
uploaded. But if the server wants to return early in this case it doesn't
know how many compressed bytes would have been uploaded (the client might
not know this ahead of time either). So let's require that the server
set committed_size to -1 in this case.

For early return to work, we also need to ensure that the server does
not return an error code.

Resolves bazelbuild#212.
    @mostynb
    mostynb committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    806ecdb View commit details
    Browse the repository at this point in the history