Straighten up the references to "cpu" in transition_support.bzl, as the definitions are somewhat inconsistent throughout. #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he definitions are somewhat inconsistent throughout. Standardizing on referring to the part of a cpu string following the platform (i.e. "sim_arm64" in "ios_sim_arm64") as "environment_arch", the architecture as "arch", and "cpu" to refer to fully formed --cpu strings when possible. (cherry picked from commit 22e836e)
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
keith
referenced
this pull request
Aug 11, 2023
…he definitions are somewhat inconsistent throughout. Standardizing on referring to the part of a cpu string following the platform (i.e. "sim_arm64" in "ios_sim_arm64") as "environment_arch", the architecture as "arch", and "cpu" to refer to fully formed --cpu strings when possible. PiperOrigin-RevId: 468803326
brentleyjones
approved these changes
Aug 11, 2023
keith
deleted the
ks/straighten-up-the-references-to-cpu-in-transition_support.bzl-as-the-definitions-are-somewhat-inconsistent-throughout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizing on referring to the part of a cpu string following the
platform (i.e. "sim_arm64" in "ios_sim_arm64") as "environment_arch",
the architecture as "arch", and "cpu" to refer to fully formed --cpu
strings when possible.
(cherry picked from commit 22e836e)