Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

describe: get the object kind from the config #114

Closed
wants to merge 2 commits into from

Conversation

nictuku
Copy link

@nictuku nictuku commented Feb 21, 2018

This should fix #113 by showing all resources found in the config.

Does this mean we can actually remove the "kind" attribute from the bazel rules and instead always read it from the config directly - like we're doing here?

I believe that with this change, we don't need kind anywhere else, or do we?

@bazel-io
Copy link
Member

Can one of the admins verify this patch?

@nictuku
Copy link
Author

nictuku commented Feb 27, 2018

Heads-up that the CI test failure is expected. The travis CI is failing only because it refuses to run the tests when the PR is coming from an untrusted repo (which is the case).

I assume admins should be able to inspect the code and trigger a manual CI if they don't think my code will grab their credentials :).

@mattmoor
Copy link
Contributor

@nictuku I wish Travis were that smart. Sadly I need to merge this into a branch on the main repo and reopen the PR to get things to run properly. You should rebase before I do that :)

You are right that kind should no longer be needed (hooray!). We should switch the assorted rules that take it to print a warning if it's specified (noting that it will become an error in the future).

Other things this enables:

  1. We no longer need to predicate .describe on the presence of kind
  2. k8s_objects can now work on .describe as well (since I think it should always be there)

@mattmoor mattmoor self-requested a review February 27, 2018 05:36
@nictuku
Copy link
Author

nictuku commented Feb 28, 2018

OK from what you're saying the next step is for me to rebase. I'll do it ASAP. Thanks!

@fejta
Copy link
Contributor

fejta commented Jun 26, 2018

Do you have an ETA for rebasing? Please do and update this PR.

Please close the PR if it is no longer needed and/or you no longer plan to work on it.

@nictuku
Copy link
Author

nictuku commented Jun 26, 2018

I don't need this at the moment so I'll just close it.

@nictuku nictuku closed this Jun 26, 2018
@nictuku nictuku deleted the describe-multi branch June 26, 2018 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.describe doesn't work if k8s template creates multiple resources
4 participants