-
Notifications
You must be signed in to change notification settings - Fork 136
fix hellogrpc/py examples by adding dependency #151
Conversation
* All current Travis CI would fail because hellogrpc/py e2e test would fail. This PR fix this test, so that Travis CI works again. * hellogprc/py server would produce a py_image which is failed to start because of missing a dependency: ``` bash Traceback (most recent call last): File "/app/hello_grpc/py/server/server.binary.runfiles/__main__/hello_grpc/py/server/server.py", line 1, in <module> import grpc File "/app/hello_grpc/py/server/server.binary.runfiles/pypi__grpcio_1_6_0/grpc/__init__.py", line 22, in <module> from grpc._cython import cygrpc as _cygrpc File "src/python/grpcio/grpc/_cython/cygrpc.pyx", line 17, in init grpc._cython.cygrpc (src/python/grpcio/grpc/_cython/cygrpc.c:29041) ``` * Adding setuptools in requirements fixes the problem.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @erain. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @nlopezgi @xingao267 Could you help review this PR? |
* The current travis ci gets stuck when executing `docker login`. Try using another option to see whether it solves the problem.
@@ -18,7 +18,7 @@ addons: | |||
|
|||
before_install: | |||
# Log into GCR | |||
- docker login -u _json_key -p "${GOOGLE_JSON_KEY}" https://us.gcr.io | |||
- echo "${GOOGLE_JSON_KEY}" | docker login -u _json_key --password-stdin https://us.gcr.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the issue. Travis only provides a password to PRs from a branch on the repo.
You should revert this with:
git reset --hard HEAD~1
and reopen this PR from a branch on the bazelbuild repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got stuck on this for a while and many thanks!!!
So for external PRs, we need to first review / approve it, then create a PR on the bazelbuild repo?
All current Travis CI would fail because hellogrpc/py e2e test would
fail. This PR fix this test, so that Travis CI works again.
hellogprc/py server would produce a py_image which is failed to
start because of missing a dependency: