Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

fix hellogrpc/py examples by adding dependency #151

Closed
wants to merge 3 commits into from

Conversation

erain
Copy link
Contributor

@erain erain commented Jun 28, 2018

  • All current Travis CI would fail because hellogrpc/py e2e test would
    fail. This PR fix this test, so that Travis CI works again.

  • hellogprc/py server would produce a py_image which is failed to
    start because of missing a dependency:

Traceback (most recent call last):
  File "/app/hello_grpc/py/server/server.binary.runfiles/__main__/hello_grpc/py/server/server.py", line 1, in <module>
    import grpc
  File "/app/hello_grpc/py/server/server.binary.runfiles/pypi__grpcio_1_6_0/grpc/__init__.py", line 22, in <module>
    from grpc._cython import cygrpc as _cygrpc
  File "src/python/grpcio/grpc/_cython/cygrpc.pyx", line 17, in init grpc._cython.cygrpc (src/python/grpcio/grpc/_cython/cygrpc.c:29041)
  • Adding setuptools in requirements fixes the problem.

* All current Travis CI would fail because hellogrpc/py e2e test would
  fail. This PR fix this test, so that Travis CI works again.

* hellogprc/py server would produce a py_image which is failed to
  start because of missing a dependency:

``` bash
Traceback (most recent call last):
  File "/app/hello_grpc/py/server/server.binary.runfiles/__main__/hello_grpc/py/server/server.py", line 1, in <module>
    import grpc
  File "/app/hello_grpc/py/server/server.binary.runfiles/pypi__grpcio_1_6_0/grpc/__init__.py", line 22, in <module>
    from grpc._cython import cygrpc as _cygrpc
  File "src/python/grpcio/grpc/_cython/cygrpc.pyx", line 17, in init grpc._cython.cygrpc (src/python/grpcio/grpc/_cython/cygrpc.c:29041)
```

* Adding setuptools in requirements fixes the problem.
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @erain. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@erain
Copy link
Contributor Author

erain commented Jun 28, 2018

/ok-to-test

@erain erain requested a review from mattmoor June 28, 2018 14:55
@erain
Copy link
Contributor Author

erain commented Jun 28, 2018

/assign @nlopezgi @xingao267

Could you help review this PR?

erain and others added 2 commits June 28, 2018 10:57
* The current travis ci gets stuck when executing `docker login`. Try
  using another option to see whether it solves the problem.
@@ -18,7 +18,7 @@ addons:

before_install:
# Log into GCR
- docker login -u _json_key -p "${GOOGLE_JSON_KEY}" https://us.gcr.io
- echo "${GOOGLE_JSON_KEY}" | docker login -u _json_key --password-stdin https://us.gcr.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the issue. Travis only provides a password to PRs from a branch on the repo.

You should revert this with:

git reset --hard HEAD~1

and reopen this PR from a branch on the bazelbuild repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got stuck on this for a while and many thanks!!!

So for external PRs, we need to first review / approve it, then create a PR on the bazelbuild repo?

@mattmoor mattmoor closed this Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants