Sprinkle some sleeps to try and improve e2e flakiness #216
Conversation
|
@fejta Passed in one shot! Maybe I got lucky? |
| # Wait some more for after IP address allocation for the service to come | ||
| # alive | ||
| echo "Got IP Adress! Sleeping 30s more for service to come alive..." | ||
| sleep 30 |
There was a problem hiding this comment.
We have had to loop multiple times waiting on LBs. I would recommend putting in a couple of 30 second loops.
|
We need a rebase |
|
@fejta is prow not doing the needs rebase label on this repo? |
I see an option to "Update branch" which will likely do the rebase. I'll check this in for now and address your comment about looping the sleep if the context cancellation errors show up again |
|
Ah it retriggered the tests. Let's see what happens shall we |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, fejta, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@smukherj1 prow has an option to check if PRs need a rebase and tags the PR automatically. Does not seem to be doing that |
|
Oh snap |
|
Can we add logging about the quotas? I'm really concerned that this is an issue :) I never trust error messages to be related to the actual problem in e2e |
|
New changes are detected. LGTM label has been removed. |
No description provided.