Bugfix: Extracts short_path from tarball-File

[dtennander]

This removes the bug not allowing k8s_object() to work on images from docker_build() targets with a legacy layer.

I saw your pending change to move from .short_path and this will need updating as well.

And good job with rules_k8s! :)
//David, from Cinnober

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[bazel-io]

Can one of the admins verify this patch?

[dtennander]

Here is a comment to trigger a new check on the CLA, as I have added @cinnober.com as an alternative adress.

[googlebot]

CLAs look good, thanks!

[mattmoor]

@DiTo04 thanks, this looks right. I really wish Travis had a way for me to tell it to run tests with secrets :-/

[mattmoor]

@DiTo04 I updated my PR to drop .short_path as well if you want to give it another shot.

Out of curiosity, do you know why you are running into the legacy tarball path?

There are some places it is unavoidable, e.g. coming from docker save like this.

There are also places it is avoidable, but an unnecessary .tar has been specified like this.

The TMI version is here, but suffice it to say that if you can avoid this path, things should be faster.

[dtennander]

I was specifying the docker_build to use the .tar... I changed that and it works like a charm. Thank you for noticing! :)

[mattmoor]

No problem, I'm glad it was so easy :)