Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakage with Bazel@HEAD #419

Closed
lberki opened this issue Feb 16, 2021 · 5 comments
Closed

Breakage with Bazel@HEAD #419

lberki opened this issue Feb 16, 2021 · 5 comments

Comments

@lberki
Copy link
Collaborator

lberki commented Feb 16, 2021

rules_python is broken on the continuous integration tests of Bazel @ HEAD:

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1905#e9759395-101f-4047-b7c9-daa0fc4eb714

This breakage is probably caused by bazelbuild/bazel@0080572 that calls test binaries in external repositories not using their legacy external/$REPO/$REPO_RELATIVE_PATH path but the canonical ../$REPO/$REPO_RELATIVE_PATH one.

I haven't looked into what the mechanism of the breakage is; my guess is that test binaries try to find data files relative to $0 and that logic needs to be updated

This issue is also available in our continuous-integration repository as bazelbuild/continuous-integration#1094 .

@lberki
Copy link
Collaborator Author

lberki commented Feb 16, 2021

/cc @philwo @gyias @c-parsons

@gyias
Copy link
Member

gyias commented Feb 17, 2021

@comius
Copy link
Contributor

comius commented Feb 19, 2021

Breakage is caused by bazelbuild/bazel@7149f57, sorry.

bazel-io pushed a commit to bazelbuild/bazel that referenced this issue Feb 19, 2021
Fixes a bunch of downstream breakages:

bazelbuild/continuous-integration#1093
bazelbuild/continuous-integration#1094
bazel-contrib/rules_nodejs#2464
bazelbuild/rules_python#419

Turns out, the assertion that "Merkle tree computation uses `ActionInput.getExecPath()`" was only mostly correct: there was a place where the key of the input map was used instead.

I'm somewhat surprised that this did not show up in our test battery, although, admittedly, "unsound directory as an input file in an external repository" doesn't sound like the most common use case.

RELNOTES: None.
PiperOrigin-RevId: 358366246
@comius
Copy link
Contributor

comius commented Feb 19, 2021

@comius comius closed this as completed Feb 19, 2021
@thundergolfer
Copy link
Collaborator

Thanks @comius

coeuvre pushed a commit to coeuvre/bazel that referenced this issue Jul 15, 2021
… .

Fixes a bunch of downstream breakages:

bazelbuild/continuous-integration#1093
bazelbuild/continuous-integration#1094
bazel-contrib/rules_nodejs#2464
bazelbuild/rules_python#419

Turns out, the assertion that "Merkle tree computation uses `ActionInput.getExecPath()`" was only mostly correct: there was a place where the key of the input map was used instead.

I'm somewhat surprised that this did not show up in our test battery, although, admittedly, "unsound directory as an input file in an external repository" doesn't sound like the most common use case.

RELNOTES: None.
PiperOrigin-RevId: 358366246
coeuvre pushed a commit to coeuvre/bazel that referenced this issue Jul 15, 2021
… .

Fixes a bunch of downstream breakages:

bazelbuild/continuous-integration#1093
bazelbuild/continuous-integration#1094
bazel-contrib/rules_nodejs#2464
bazelbuild/rules_python#419

Turns out, the assertion that "Merkle tree computation uses `ActionInput.getExecPath()`" was only mostly correct: there was a place where the key of the input map was used instead.

I'm somewhat surprised that this did not show up in our test battery, although, admittedly, "unsound directory as an input file in an external repository" doesn't sound like the most common use case.

RELNOTES: None.
PiperOrigin-RevId: 358366246
coeuvre pushed a commit to coeuvre/bazel that referenced this issue Jul 16, 2021
… .

Fixes a bunch of downstream breakages:

bazelbuild/continuous-integration#1093
bazelbuild/continuous-integration#1094
bazel-contrib/rules_nodejs#2464
bazelbuild/rules_python#419

Turns out, the assertion that "Merkle tree computation uses `ActionInput.getExecPath()`" was only mostly correct: there was a place where the key of the input map was used instead.

I'm somewhat surprised that this did not show up in our test battery, although, admittedly, "unsound directory as an input file in an external repository" doesn't sound like the most common use case.

RELNOTES: None.
PiperOrigin-RevId: 358366246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants