-
Notifications
You must be signed in to change notification settings - Fork 426
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not pass native deps to rlib compilations (#576)
When creating an rlib artifact, rustc will open every native static library and "copy" its contents into the rlib. This results in a quadratic disk usage growth and that's not necessary for rules_rust because we track native dependencies are we can safely pass them to the final linking actions. This fixes the build failure when a native dep is actually a linker script. Rustc will try to open the linker script as if it was a static archive, and then fail the build. Creating shared library artifacts (dylib, cdylib) and binaries is not affected, for those rustc uses the linker, and linker will consume the linker script just fine. Rustc won't try to open/interpret the linker script itself. This also unblocks #562.
- Loading branch information
Showing
13 changed files
with
282 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Copyright 2015 The Bazel Authors. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Module with Rust definitions required to write custom Rust rules.""" | ||
|
||
CrateInfo = provider( | ||
doc = "A provider containing general Crate information.", | ||
fields = { | ||
"aliases": "Dict[Label, String]: Renamed and aliased crates", | ||
"deps": "List[Provider]: This crate's (rust or cc) dependencies' providers.", | ||
"edition": "str: The edition of this crate.", | ||
"is_test": "bool: If the crate is being compiled in a test context", | ||
"name": "str: The name of this crate.", | ||
"output": "File: The output File that will be produced, depends on crate type.", | ||
"proc_macro_deps": "List[CrateInfo]: This crate's rust proc_macro dependencies' providers.", | ||
"root": "File: The source File entrypoint to this crate, eg. lib.rs", | ||
"rustc_env": "Dict[String, String]: Additional `\"key\": \"value\"` environment variables to set for rustc.", | ||
"srcs": "List[File]: All source Files that are part of the crate.", | ||
"type": "str: The type of this crate. eg. lib or bin", | ||
}, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# BUILD file intentionally left empty |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
load(":native_deps_test.bzl", "native_deps_test_suite") | ||
|
||
############################ UNIT TESTS ############################# | ||
native_deps_test_suite(name = "native_deps_test_suite") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
extern "C" { | ||
fn native_dep() -> isize; | ||
} | ||
fn main() { | ||
println!("{}", unsafe { native_dep() }) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
extern "C" { | ||
fn native_dep() -> isize; | ||
} | ||
pub fn use_native_dep() { | ||
println!("{}", unsafe { native_dep() }) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
extern "C" int native_dep() { return 42; } |
Oops, something went wrong.