Add SemanticDB support - cont. #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icdb Mpeterson/semanticdb
This reverts commit 110442d.
This reverts commit 39b10b2.
This reverts commit cb07f15.
This reverts commit 993aa30.
This reverts commit 166c1f0.
This reverts commit 8fcbbc9.
This reverts commit 1e4df56.
Also bump versions of its dependencies: * org.ow2.asm:asm: 6.1.1 -> 9.0 * net.sf.jopt-simple:jopt-simple: 4.6 -> 5.0.4
|
I hope we can merge this soon. It's been a long-missing capability. |
|
@crt-31 sorry for the delay with a review. I'm currently on my PTO, I'll do a proper review after two weeks if this can wait. I quickly went over changes - implementation looks good. I want to do some testing and a bit of naming nit-picking when I'll be back for a proper review. |
- fixed semanticdb example - added prefix '_' to semanticdb output path - renamed certain vars to not prepend with "scala_" - changed depsprovider var name to be plural instead of singular
|
@liucijus, are you able to rerun the CI tests for this PR? It seems to have hung for some reason. |
Unfortunately, no, but let's ignore it as it's flaky |
liucijus
approved these changes
Sep 18, 2023
simuons
approved these changes
Oct 2, 2023
7 tasks
This was referenced Nov 30, 2023
Closed
Closed
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Semanticdb output capability
This PR extends the PR drafts #1467 and #1329, and as such builds on the great work so far by @olafurpg and @ricochet1k, and @aishfenton. In particular, this PR moves the semanticddb handling into a phase instead of the scalacworker, as well as some other improvements.
Features
scala_toolchain.enable_semanticdb. Default is False for performance reasons (generating semanticdb adds considerable overhead to a build).Motivation
Semanticdb is needed by many tools and IDEs (i.e. Metals, Scalafix, etc). This will hopefully support integration of more tools with rules_scala and help accelerate its usage in the community.