JacocoRunner script: update for Bazel 6.0+ #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a parameter to specify the Bazel major version (to have a single script for Bazel 5 and 6). Manually tested on a repo with both Bazel versions. Had to add a new patch file for Bazel 6. Added new Bazel branch with the Jacoco interface implementation, updated for Bazel 6.3.2. Updated manual test_coverage_with_local_jacocorunner to run the script with Bazel 6 provided as a parameter (it was failing after the repo's upgrade to Bazel 6).
simuons
requested changes
Sep 28, 2023
…efault The script for Bazel 5/6 should be the default one. Leaving the version for Bazel 4 as an alternative with a version suffix in its filename.
I think the issue is now fixed. |
liucijus
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter to specify the Bazel major version (to have a single script for Bazel 5 and 6).
Manually tested on a repo with both Bazel versions.
Had to add a new patch file for Bazel 6.
Added new Bazel branch with the Jacoco interface implementation, updated for Bazel 6.3.2.
Updated manual test_coverage_with_local_jacocorunner to run the script with Bazel 6 provided as a parameter (it was failing after the repo's upgrade to Bazel 6).