Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for source jars to scala_library #33

Merged
merged 1 commit into from
Apr 19, 2016

Conversation

jcoveney
Copy link
Contributor

@jcoveney jcoveney commented Apr 18, 2016

This is pulled out from #29

This adds support for source jars. This will be used and tested immediately by another PR

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jcoveney
Copy link
Contributor Author

closes #2

# Make jar file deterministic by setting the timestamp of files
rm -rf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are we removing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. fixed. this is from when I was moving around how the srcjar stuff was expanded

@johnynek johnynek added cla: yes and removed cla: no labels Apr 19, 2016
@johnynek
Copy link
Member

👍 will merge when green.

@johnynek johnynek merged commit 8801396 into bazelbuild:master Apr 19, 2016
@jcoveney jcoveney deleted the jco/scala_srcjar branch April 19, 2016 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants