-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for source jars to scala_library #33
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
3e124ce
to
a891b6f
Compare
closes #2 |
a891b6f
to
9eed4a0
Compare
# Make jar file deterministic by setting the timestamp of files | ||
rm -rf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are we removing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. fixed. this is from when I was moving around how the srcjar stuff was expanded
9eed4a0
to
a362217
Compare
a362217
to
49877d5
Compare
👍 will merge when green. |
This is pulled out from #29
This adds support for source jars. This will be used and tested immediately by another PR