Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable local cache #502

Closed
wants to merge 1 commit into from
Closed

Conversation

buchgr
Copy link
Contributor

@buchgr buchgr commented May 16, 2018

@buchgr Starting with Bazel 0.14 these flags no longer exist and have been replaced by
the --disk_cache flag. We want to maintain compatibility with older Bazel versions
and thus we have to remove these flags for now.

Fixes #498.

Starting with Bazel 0.14 these flags no longer exist and have been replaced by
the --disk_cache flag. We want to maintain compatibility with older Bazel versions
and thus we have to remove these flags for now.
@ittaiz
Copy link
Member

ittaiz commented May 17, 2018

this is just from a github search, right? since @philwo removed our usage (#495) of this in buildkite saying that:

Local disk caching does not work on Bazel's CI and actually causes the project to fail in our downstream tests at the moment

The other problem is that our travis is currently stuck on 0.11.1 which also means @dslomov's solution in #501 won't work.
If you're not seeing an actual problem but just want to clean it up then I'll close this one and keep #501 open until I fix the travis to work with at least 0.13.0

WDYT?

@dslomov
Copy link
Contributor

dslomov commented May 17, 2018

It actually causes failures on CI: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/232#1cd8b9e4-c91f-4152-9c39-53b6e8a8032b (can you see that?)
I do not know why #495 does not remove tools/bazel.rc from rules_scala. @buchgr wdyt?

@ittaiz
Copy link
Member

ittaiz commented May 18, 2018

can you please look now after #504 was merged?

@buchgr buchgr closed this May 22, 2018
@ittaiz
Copy link
Member

ittaiz commented May 22, 2018 via email

@buchgr
Copy link
Contributor Author

buchgr commented May 22, 2018

Hi ittai,

it turned out that we had a bug in our CI setup. We would run bazel info before even reading the presubmit.yml CI configuration. bazel info would pick up flags from the .bazelrc file and fail as they no longer exist. I have updated our ci to do bazel --nomaster_rc --bazelrc=/dev/null info instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants