Fix jvm_flag support #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -174,7 +174,7 @@ SourceJars: {srcjars} | |||
| javac_opts=" ".join(ctx.attr.javacopts), | |||
| javac_path=ctx.file._javac.path, | |||
| java_files=",".join([f.path for f in java_srcs]), | |||
| jvm_flags=" ".join(["-J" + flag for flag in ctx.attr.jvm_flags]), | |||
| jvm_flags=" ".join(ctx.attr.jvm_flags), | |||
There was a problem hiding this comment.
I think you need the -J still here, these are for java
|
LGTM |
petemounce
pushed a commit
to improbable-io/rules_scala
that referenced
this pull request
Oct 20, 2016
* upstream/master: use strings rather than HOST/DATA_CFG Add cfg attribute on executable labels Switch to using shorter stack traces. Catch throwables from type errors make thrift targets quieter (bazelbuild#94) Fix jvm_flag support (bazelbuild#93) Make compile timing optional, with default false Update README.md Persistent/worker scala compiler (bazelbuild#91) fix typo in README.md (bazelbuild#89) Fix for thrift rule issue that manifests with remote repos (bazelbuild#83) improve the deploy jar creation (bazelbuild#85) Use bind's for twitter scrooge so local repo's can override scrooge and thrift versions (bazelbuild#84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel java binary targets have certain options:
https://github.com/bazelbuild/bazel/blob/c1b417549cf4ba719662f7562e99e807c606eae7/src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt
use:
to set the jvm flags.