-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pass default_shell_env through actions
Through the investigation of bazelbuild/bazel#12049 one of the things I discovered was that when using `actions.run` there are 2 options for environment variables. `use_default_shell_env = True` is recommended, but cannot be used if you want to also pass `env` to the actions. To support Xcode version selection we have to pass `env` with those variables. Without the default shell env, we only get the environment variables defined in the crosstool, but not those passed with `--action_env`. This now adds variables passed as `--action_env=FOO=BAR`, but not those passed as `--action_env=FOO` (where the value is supposed to pass through). This is useful to ensure a few things: 1. The default PATH things are executed with includes /usr/local/bin. This can result in pollution of binaries from homebrew. Previously there was no way to limit this 2. This should be a good replacement for using custom Swift toolchains. Currently those environment variables only apply to some actions (excluding those from bazel) using `--action_env=TOOLCHAINS=foo` should work better than the current solution (this change can be made as a followup)
- Loading branch information
1 parent
3d6141f
commit c5b0e71
Showing
6 changed files
with
21 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters