fix(ssr): ssrTransform handling for empty ArrayPattern (vitejs#5988)

bbbboom · Dec 7, 2021 · 79aa687 · 79aa687
1 parent 1102789
commit 79aa687
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts b/packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts
@@ -375,3 +375,9 @@ test('overwrite bindings', async () => {
     "
   `)
 })
+
+test('Empty array pattern', async () => {
+  expect(
+    (await ssrTransform(`const [, LHS, RHS] = inMatch;`, null, null)).code
+  ).toMatchInlineSnapshot(`"const [, LHS, RHS] = inMatch;"`)
+})
diff --git a/packages/vite/src/node/ssr/ssrTransform.ts b/packages/vite/src/node/ssr/ssrTransform.ts
@@ -347,7 +347,7 @@ function walk(
               }
             })
           } else if (node.id.type === 'ArrayPattern') {
-            node.id.elements.forEach((element) => {
+            node.id.elements.filter(Boolean).forEach((element) => {
               setScope(parentFunction, (element as Identifier).name)
             })
           } else {