Fix for full viewport of 375px for potrait images #5610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wport-for-375px-images
rhenshaw56
added
bug
rhenshaw56
changed the title
12
approved these changes
Feb 20, 2020
| @@ -35,6 +35,7 @@ const ArticleFigure = ({ | |||
| }) => { | |||
| const imageSpan = { | |||
| default: '6', | |||
| group1: '6', | |||
There was a problem hiding this comment.
Groups will inherit the default value, so setting group1 to the same value is unnecessary. This change works, because portrait images have a different default value. We should probably apply this rule within the control block on line 47 instead. E.G.:
if (height > width) {
ParentWrapper = NestedGridParentSmall;
ChildWrapper = NestedGridItemChildSmall;
imageSpan.default = '4';
imageSpan.group1 = '6';
}There was a problem hiding this comment.
Great suggestion. Thanks @simonsinclair
…wport-for-375px-images
…bc/simorgh into full-viewport-for-375px-images
12
approved these changes
Feb 20, 2020
|
Looks good the potrait and all images seem to occupy the entire viewport at widths < 375px. Tested across browsers and devices only on Samsung galaxy s10(android 10) the images still dont occupy full width tested on BS but on other devices of same viewport as S10 it looks good. |
|
May be we should merge it and when on test should look on a real device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5525
Overall change:
N/B: This is for just gel group1, portrait Images will still preserve their default grid span of 4 ie ( > 375px)
Code changes:
- Adds grid image span for gel group1 ( ~ 375px)
Testing:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)