Fixes a codesearch bug in the index writer.

bbuddha · Mar 23, 2017 · f26a064 · f26a064
1 parent c68f905
commit f26a064
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/codesearch/index/write.go b/codesearch/index/write.go
@@ -483,6 +483,7 @@ func (h *postHeap) siftUp(j int) {
 			break
 		}
 		ch[i], ch[j] = ch[j], ch[i]
+		j = i
 	}
 }
 

diff --git a/codesearch/index/write_test.go b/codesearch/index/write_test.go
@@ -163,3 +163,19 @@ func TestTrivialWrite(t *testing.T) {
 func TestTrivialWriteDisk(t *testing.T) {
 	testTrivialWrite(t, true)
 }
+
+func TestHeap(t *testing.T) {
+	h := &postHeap{}
+	es := []postEntry{7, 4, 3, 2, 4}
+	for _, e := range es {
+		h.addMem([]postEntry{e})
+	}
+	if len(h.ch) != len(es) {
+		t.Fatalf("wrong heap size: %d, want %d", len(h.ch), len(es))
+	}
+	for a, b := h.next(), h.next(); b.trigram() != (1<<24 - 1); a, b = b, h.next() {
+		if a > b {
+			t.Fatalf("%d should <= %d", a, b)
+		}
+	}
+}