fix(mr_create/issue_create): add encoding to title and change descrip…

…tion encoding (profclems#871)

* fix(mr_create/issue_create): add encoding to title and change description encoding

- Prevent browsers from converting a space containing query to a search query
- Allow users to add symbols to their title and description
    - QueryEscape does not escape '+' which is converted to a space by the browser

* fix(issue_create) : remove unused repo parameter

* fix(issue_create/mr_create) : manually encode + to %2B

* fix(issue_create/mr_create) : prevent open from auto encoding characters

The tick on the URL makes `open` on a mac encode it, so already encoded data such as a %20 is encoded to %2520
Removing the utf8=`tick` prevents auto encoding and makes urls work as is allowing symbols to be used in title and description

Co-authored-by: Kartikay Shandil <kartikays@sahaj.ai>

commands/issue/create/issue_create.go

@@ -368,7 +368,7 @@ func previewIssue(opts *CreateOpts) error {
 		return err
 	}
 
-	openURL, err := generateIssueWebURL(opts, repo)
+	openURL, err := generateIssueWebURL(opts)
 	if err != nil {
 		return err
 	}
@@ -380,7 +380,7 @@ func previewIssue(opts *CreateOpts) error {
 	return utils.OpenInBrowser(openURL, browser)
 }
 
-func generateIssueWebURL(opts *CreateOpts, repo glrepo.Interface) (string, error) {
+func generateIssueWebURL(opts *CreateOpts) (string, error) {
 	description := opts.Description
 
 	if len(opts.Labels) > 0 {
@@ -415,8 +415,8 @@ func generateIssueWebURL(opts *CreateOpts, repo glrepo.Interface) (string, error
 	}
 	u.Path += "/-/issues/new"
 	u.RawQuery = fmt.Sprintf(
-		"utf8=✓&issue[title]=%s&issue[description]=%s",
-		opts.Title,
-		url.QueryEscape(description))
+		"issue[title]=%s&issue[description]=%s",
+		strings.ReplaceAll(url.PathEscape(opts.Title), "+", "%2B"),
+		strings.ReplaceAll(url.PathEscape(description), "+", "%2B"))
 	return u.String(), nil
 }

commands/mr/create/mr_create.go

@@ -684,9 +684,9 @@ func generateMRCompareURL(opts *CreateOpts) (string, error) {
 	}
 	u.Path += "/-/merge_requests/new"
 	u.RawQuery = fmt.Sprintf(
-		"utf8=✓&merge_request[title]=%s&merge_request[description]=%s&merge_request[source_branch]=%s&merge_request[target_branch]=%s&merge_request[source_project_id]=%d&merge_request[target_project_id]=%d",
-		url.QueryEscape(opts.Title),
-		url.QueryEscape(description),
+		"merge_request[title]=%s&merge_request[description]=%s&merge_request[source_branch]=%s&merge_request[target_branch]=%s&merge_request[source_project_id]=%d&merge_request[target_project_id]=%d",
+		strings.ReplaceAll(url.PathEscape(opts.Title), "+", "%2B"),
+		strings.ReplaceAll(url.PathEscape(description), "+", "%2B"),
 		opts.SourceBranch,
 		opts.TargetBranch,
 		opts.SourceProject.ID,