Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI to run drupal-test-traits etc #43

Closed
2 of 4 tasks
Tracked by #482
sylus opened this issue Jun 20, 2023 · 13 comments
Closed
2 of 4 tasks
Tracked by #482

Improve CI to run drupal-test-traits etc #43

sylus opened this issue Jun 20, 2023 · 13 comments
Assignees
Labels
devops DevOps and Deployment related tasks Icebox Items that have been discussed and deferred, likely indefinitely. Phase 4 - Sprint 2 July 23- Sept 16, 2024 Sprint 17 April 25 - May 16 Sprint 18 May 17 - May 30

Comments

@sylus
Copy link
Contributor

sylus commented Jun 20, 2023

OP timer

https://openplus.monday.com/boards/4092908516/pulses/6509122573


Overview

Right now the CI just performs a standard Drupal site install along with phpcs before it builds the container and then pushes them to Artifactory.

We instead should be grabbing a minimized test DB with limited data so we can run drupal-test-traits etc in our CI and ensure all of our test cases pass in an automated fashion.

We weren't able to do this for RSAMS due to the sheer size of the DB but for MFIN Data Catalogue this should be doable.

Blocker(s)

  • Waiting for a DB to perform tests against @lkmorlan

Work

  • Retrieve a minimized / cleansed DB @sylus
  • Establish automated process to get newer minimized DB @sylus
  • Need to update phpunit.xml which references DV21 @lkmorlan

The problem becomes where to host this DB so GitHub actions can pull it done. As a stop gap we could grab these databases from an Azure Storage Account but something official from BCGov would be idea.

Not sure how pressing of an issue this is but nonetheless I am documenting it.

@sylus sylus added the devops DevOps and Deployment related tasks label Jun 20, 2023
@sylus sylus added this to the Deployment and DevOps milestone Jun 20, 2023
@sylus sylus self-assigned this Jun 20, 2023
@sylus sylus changed the title Improve CI to run testing suite Improve CI to run drupal-test-traits and other functional tests Jun 20, 2023
@sylus sylus changed the title Improve CI to run drupal-test-traits and other functional tests Improve CI to run drupal-test-traits and other test suites Jun 20, 2023
@sylus sylus changed the title Improve CI to run drupal-test-traits and other test suites Improve CI to run drupal-test-traits etc Jun 20, 2023
@sylus
Copy link
Contributor Author

sylus commented May 6, 2024

Hi @CraigClark so this has never been actioned and right now the default CI tests are more for just linting and testing an install which are pretty small tests. I would need to work with @lkmorlan on this and there are problems above that need to be solved.

@CraigClark CraigClark added the Sprint 17 April 25 - May 16 label May 6, 2024
@CraigClark
Copy link
Collaborator

Thanks @sylus , I've added @lkmorlan to the ticket and moved it into sprint. Could you please work with him to do whatever needs doing?

@lkmorlan
Copy link
Collaborator

lkmorlan commented May 6, 2024

The references to dv21 can be changed anytime. I run tests now on dv14. To make the tests work, I set environment variables that refer to dv14.

I can make a fresh minimal site install with just the content needed for the tests.

@lkmorlan
Copy link
Collaborator

lkmorlan commented May 7, 2024

@sylus A dump file containing a minimal database is on the dv server in /home/ec2-user/dv14-pg_dump-2024-05-07.sql.gz. I have successfully run ExistingSite tests on this site.

@sylus
Copy link
Contributor Author

sylus commented May 23, 2024

@CraigClark so the question is where can we store this db image such that the actions runner can use it?

I don't think we can put this image in a public location.

Does BCGov have a place like an azure storage account where we could put this such that they can pull from?

@NicoledeGreef
Copy link
Collaborator

NicoledeGreef commented May 27, 2024

Location for storage of DB image needed; I will request S3 object storage. I surmise that it will not be in place before June.

@NicoledeGreef
Copy link
Collaborator

Putting this ticket on hold until the object storage is established.

@NicoledeGreef NicoledeGreef added the stuck Something is preventing further work on this issue label Jun 21, 2024
@NicoledeGreef NicoledeGreef removed the stuck Something is preventing further work on this issue label Jul 15, 2024
@NicoledeGreef NicoledeGreef added the Phase 4 - Sprint 2 July 23- Sept 16, 2024 label Aug 14, 2024
@NicoledeGreef
Copy link
Collaborator

S3 Object Storage bucket is now available (see #506).

@NicoledeGreef NicoledeGreef added the Icebox Items that have been discussed and deferred, likely indefinitely. label Aug 19, 2024
@NicoledeGreef
Copy link
Collaborator

NicoledeGreef commented Aug 19, 2024

We need insight from a devOps expert on how to proceed if we are to set up the testing infrastructure using the github actions and minimized db in Object Storage.

@Ntirukovela
Copy link

@NicoledeGreef - Can we update list of items to discuss . Our team can start reviewing internally and get back to you

@NicoledeGreef
Copy link
Collaborator

@Ntirukovela the dev team is meeting on Monday and we'll discuss this ticket and get back to you on what support we need,

@NicoledeGreef
Copy link
Collaborator

We're closing this ticket. We will consult and work up a list but nothing imminent required from AppOps at this time.

@chrislaick
Copy link
Collaborator

@chrislaick will add this to the questions list for Will Hearn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps and Deployment related tasks Icebox Items that have been discussed and deferred, likely indefinitely. Phase 4 - Sprint 2 July 23- Sept 16, 2024 Sprint 17 April 25 - May 16 Sprint 18 May 17 - May 30
Projects
Development

No branches or pull requests

7 participants