Feature/Added tvOS-UITests #27

FraDeliro · 2018-10-07T12:53:34Z

Purpose

This is a feature to add UITests for tvOS.

A brief description of what has changed and why it has changed

Added:

Example_tvOSUITests.swift

Ways to test feature or scenarios to try

Run the tests for tvOS example app.

houndci-bot · 2018-10-07T12:53:40Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Option 3").element, handler: nil)


Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

houndci-bot · 2018-10-07T12:53:40Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Option 2").element, handler: nil)


Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

houndci-bot · 2018-10-07T12:53:41Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Option 1").element, handler: nil)


Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

houndci-bot · 2018-10-07T12:53:41Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:".value2").element, handler: nil)


Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

houndci-bot · 2018-10-07T12:53:41Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    waitForExpectations(timeout: 5, handler: nil)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:".value1").element, handler: nil)


Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

houndci-bot · 2018-10-07T12:53:42Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    waitForExpectations(timeout: 5, handler: nil)
+    XCUIRemote.shared.press(.select)
+
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Tap action").element, handler: nil)


Line Length Violation: Line should be 120 characters or less: currently 130 characters (line_length)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

houndci-bot · 2018-10-07T12:53:42Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Tap action").element, handler: nil)


Line Length Violation: Line should be 120 characters or less: currently 130 characters (line_length)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

houndci-bot · 2018-10-07T12:53:42Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Setting 2").element, handler: nil)


Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

houndci-bot · 2018-10-07T12:53:42Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    let existance = NSPredicate(format: "exists == true")
+    let hasFocus = NSPredicate(format: "hasFocus == true")
+
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Setting 1").element, handler: nil)


Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

houndci-bot · 2018-10-07T12:53:42Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    app.launch()
+  }
+
+  func testInteractions() {


Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 57 lines (function_body_length)

I think houndci has the wrong configuration. I'll fix it later.

codecov · 2018-10-07T13:04:54Z

Codecov Report

Merging #27 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #27   +/-   ##
========================================
  Coverage    94.71%   94.71%           
========================================
  Files           12       12           
  Lines          284      284           
========================================
  Hits           269      269           
  Misses          15       15

bcylin · 2018-10-08T19:52:36Z

Example-tvOSUITests/Example_tvOSUITests.swift

+
+import XCTest
+
+internal final class Example_tvOSUITests: XCTestCase {


Can you rename the file and class to ExampleUITests without the underscore?

bcylin · 2018-10-08T19:58:06Z

Example-tvOSUITests/Example_tvOSUITests.swift

+    app.launch()
+  }
+
+  func testInteractions() {


I think houndci has the wrong configuration. I'll fix it later.

bcylin · 2018-10-08T19:59:58Z

QuickTableViewController.xcodeproj/project.pbxproj

+						DevelopmentTeam = NQU669U9J9;
+						ProvisioningStyle = Automatic;
+						TestTargetID = B54A24522088D44A00EEBA26;
+					};


You probably want to remove your team ID from the project.

bcylin · 2018-10-08T20:09:19Z

Thanks for the pull request! Currently CI doesn't run Example-tvOSUITests. Can you also change bundle exec rake "build:tvos[Example-tvOS]" to test:tvos[Example-tvOS] in .travis.yml?

houndci-bot · 2018-10-09T19:21:01Z

Example-tvOSUITests/ExampleUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Option 3").element, handler: nil)


Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)

houndci-bot · 2018-10-09T19:21:01Z

Example-tvOSUITests/ExampleUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Option 2").element, handler: nil)


Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)

houndci-bot · 2018-10-09T19:21:01Z

Example-tvOSUITests/ExampleUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Option 1").element, handler: nil)


Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)

houndci-bot · 2018-10-09T19:21:01Z

Example-tvOSUITests/ExampleUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:".value2").element, handler: nil)


Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)

houndci-bot · 2018-10-09T19:21:02Z

Example-tvOSUITests/ExampleUITests.swift

+    waitForExpectations(timeout: 5, handler: nil)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:".value1").element, handler: nil)


Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)

houndci-bot · 2018-10-09T19:21:03Z

Example-tvOSUITests/ExampleUITests.swift

+    waitForExpectations(timeout: 5, handler: nil)
+    XCUIRemote.shared.press(.select)
+
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Tap action").element, handler: nil)


Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 130 characters (line_length)

houndci-bot · 2018-10-09T19:21:03Z

Example-tvOSUITests/ExampleUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Tap action").element, handler: nil)


Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 130 characters (line_length)

houndci-bot · 2018-10-09T19:21:04Z

Example-tvOSUITests/ExampleUITests.swift

+    XCUIRemote.shared.press(.select)
+
+    XCUIRemote.shared.press(.down)
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Setting 2").element, handler: nil)


Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)

houndci-bot · 2018-10-09T19:21:04Z

Example-tvOSUITests/ExampleUITests.swift

+    let existance = NSPredicate(format: "exists == true")
+    let hasFocus = NSPredicate(format: "hasFocus == true")
+
+    expectation(for: hasFocus, evaluatedWith: tables.cells.containing(.staticText, identifier:"Setting 1").element, handler: nil)


Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)

houndci-bot · 2018-10-09T19:21:04Z

Example-tvOSUITests/ExampleUITests.swift

+    app.launch()
+  }
+
+  func testInteractions() {


Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 57 lines (function_body_length)

bcylin · 2018-10-10T19:20:58Z

Example-tvOSUITests/ExampleUITests.swift

+    app.launch()
+  }
+
+  func testInteractions() {


Please try adding // swiftlint:disable function_body_length line_length above the method for the temporary fix. Sorry about @houndci-bot.

No worries ;) 👍

bcylin · 2018-10-10T20:47:16Z

Can you fix the colon violations and rebase the latest develop branch?

Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

bcylin · 2018-10-14T14:53:38Z

Thanks @FraDeliro!

FraDeliro · 2018-10-16T08:53:59Z

Thank you @bcylin ;)

FraDeliro added 3 commits October 7, 2018 14:42

Added tvOSUITestsTarget

936f5f9

Implemented testInteractions function

d125a1b

Set Example_tvOSUITests class as internal final

c72fb32

houndci-bot reviewed Oct 7, 2018

View reviewed changes

FraDeliro mentioned this pull request Oct 7, 2018

tvOS UI Testing #21

Closed

bcylin reviewed Oct 8, 2018

View reviewed changes

Add-tvOSUITests: code review required changes

05b01a9

houndci-bot reviewed Oct 9, 2018

View reviewed changes

bcylin reviewed Oct 10, 2018

View reviewed changes

Add-tvOSUITests: fixed swift lint warnings

3e77af4

bcylin merged commit 8786e6e into bcylin:develop Oct 14, 2018

FraDeliro deleted the feature/add-tvOSUITests branch October 16, 2018 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/Added tvOS-UITests #27

Feature/Added tvOS-UITests #27

FraDeliro commented Oct 7, 2018

houndci-bot Oct 7, 2018

houndci-bot Oct 7, 2018

houndci-bot Oct 7, 2018

houndci-bot Oct 7, 2018

houndci-bot Oct 7, 2018

houndci-bot Oct 7, 2018

houndci-bot Oct 7, 2018

houndci-bot Oct 7, 2018

houndci-bot Oct 7, 2018

houndci-bot Oct 7, 2018

bcylin Oct 8, 2018

codecov bot commented Oct 7, 2018 •

edited

Loading

bcylin Oct 8, 2018

bcylin Oct 8, 2018

bcylin Oct 8, 2018

bcylin commented Oct 8, 2018

houndci-bot Oct 9, 2018

houndci-bot Oct 9, 2018

houndci-bot Oct 9, 2018

houndci-bot Oct 9, 2018

houndci-bot Oct 9, 2018

houndci-bot Oct 9, 2018

houndci-bot Oct 9, 2018

houndci-bot Oct 9, 2018

houndci-bot Oct 9, 2018

houndci-bot Oct 9, 2018

bcylin Oct 10, 2018

FraDeliro Oct 11, 2018

bcylin commented Oct 10, 2018

bcylin commented Oct 14, 2018

FraDeliro commented Oct 16, 2018


		import XCTest

		internal final class Example_tvOSUITests: XCTestCase {

Feature/Added tvOS-UITests #27

Feature/Added tvOS-UITests #27

Conversation

FraDeliro commented Oct 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 7, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcylin commented Oct 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcylin commented Oct 10, 2018

bcylin commented Oct 14, 2018

FraDeliro commented Oct 16, 2018

codecov bot commented Oct 7, 2018 •

edited

Loading