Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Icon.system for SF Symbols #41

Merged
merged 7 commits into from
May 24, 2020
Merged

Added Icon.system for SF Symbols #41

merged 7 commits into from
May 24, 2020

Conversation

ezfe
Copy link
Contributor

@ezfe ezfe commented Dec 30, 2019

This adds an Icon type that pulls from UIImage(systemName:) versus UIImage(named:).

Copy link
Owner

@bcylin bcylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for the pull request! The CI build fails because init(systemName:) requires iOS 13+. It'd be better to add the API compatibility.

Source/Model/Icon.swift Outdated Show resolved Hide resolved
Source/Model/Icon.swift Outdated Show resolved Hide resolved
ezfe and others added 3 commits January 9, 2020 15:33
Co-Authored-By: Cheng-Yao Lin <b.cylin@gmail.com>
Co-Authored-By: Cheng-Yao Lin <b.cylin@gmail.com>
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #41 into develop will decrease coverage by 0.21%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop      #41      +/-   ##
===========================================
- Coverage    93.94%   93.73%   -0.22%     
===========================================
  Files           14       14              
  Lines          314      319       +5     
===========================================
+ Hits           295      299       +4     
- Misses          19       20       +1     
Impacted Files Coverage Δ
Source/Model/Icon.swift 95.23% <83.33%> (-4.77%) ⬇️

@ezfe
Copy link
Contributor Author

ezfe commented Jan 10, 2020

I see now that the code coverage is failing. I'll take a look at fixing that in a little bit.

@bcylin bcylin merged commit 17c05d7 into bcylin:develop May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants