Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cupertino widgets and all the adaptive widgets #946

Merged
merged 10 commits into from
Oct 21, 2023

Conversation

EchoEllet
Copy link
Contributor

@EchoEllet EchoEllet commented Oct 19, 2023

  localizationsDelegates: const [
        DefaultCupertinoLocalizations.delegate,
        DefaultMaterialLocalizations.delegate,
        DefaultWidgetsLocalizations.delegate,
        FluentLocalizations.delegate,
      ],

when using FluentApp.

Before:

image

After:

image

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

Copy link
Owner

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to rebase

CHANGELOG.md Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@EchoEllet
Copy link
Contributor Author

EchoEllet commented Oct 20, 2023

Hi again, You might want to consider replying to this suggestion if possible:

Why we are not using the ScrollBar (material version) widget as default for Android and Fuchsia OS??

@bdlukaa
Copy link
Owner

bdlukaa commented Oct 20, 2023

Please take a look at scroll_pos change log
it has a breaking change

#947 has fixed this. Please revert

@EchoEllet
Copy link
Contributor Author

Please take a look at scroll_pos change log
it has a breaking change

#947 has fixed this. Please revert

Done

CHANGELOG.md Outdated Show resolved Hide resolved
@bdlukaa bdlukaa merged commit 0d31350 into bdlukaa:master Oct 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants