Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to latest express-handlebars #671

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GhassenRjab
Copy link

Changes Made

Upgrade to latest express-handlebars.
This is needed as the old version of express-handlebars contains a vulnerability

Potential Risks

UI glitches after handlebars upgrade (Highly unlikely)

Test Plan

I use npm link in order to test bull-arena on a project that already uses it. I noticed no UI regressions

Checklist

  • I've increased test coverage
  • Since this is a public repository, I've checked I'm not publishing private data in the code, commit comments, or this PR.

This is needed as the old version of express-handlebars contains a vulnerability
@GhassenRjab
Copy link
Author

@roggervalf can you check the PR please? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant