Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discogs: discogs_albumid is always 0 #4225

Closed
jordanbs opened this issue Jan 6, 2022 · 6 comments · Fixed by #4303
Closed

discogs: discogs_albumid is always 0 #4225

jordanbs opened this issue Jan 6, 2022 · 6 comments · Fixed by #4303
Labels
bug bugs that are confirmed and actionable

Comments

@jordanbs
Copy link

jordanbs commented Jan 6, 2022

Most of my music is imported using the discogs plugin (beets v1.6.0, formerly imported via beets 1.4.9), but the every single discogs_albumid field is equal to 0. I do notice, however, the mb_albumid field contains what should be in discogs_albumid.

E.g.

         data_source: Discogs
     discogs_albumid: 0
    discogs_artistid: 1954908
     discogs_labelid: 1085864
    mb_albumartistid: 1954908
          mb_albumid: 10346192
   mb_releasegroupid: 1185315

Reproduce this by importing an album and using Discogs as the source. Re-importing will do.

@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Jan 7, 2022
@sampsyo
Copy link
Member

sampsyo commented Jan 7, 2022

Thanks! I expect that something changed in the Discogs API about reporting IDs, as I mentioned in #4224 (comment):

It is probably related to #4080. I think #4085 probably should have eliminated extract_release_id altogether and replaced it with the new extract_release_id_regex or similar.

To debug this, the first step would be to dump out the argument to extract_release_id and see what it consists of. If it's a URL, it probably works to just call extract_release_id_regex instead.

@sampsyo sampsyo changed the title discogs_albumid is always 0 discogs: discogs_albumid is always 0 Jan 7, 2022
@jordanbs
Copy link
Author

That works.

@JOJ0
Copy link
Member

JOJ0 commented Feb 27, 2022

@jordanbs have you found the time to open a PR for this? Or can you describe the fix here. I'm also interested in getting this fixed. Thanks :-)

@jordanbs
Copy link
Author

Unfortunately I'm not able to do that.

But you can!

On line 317 of beetsplug/discogs.py, replace extract_release_id with extract_release_id_regex.

@JOJ0
Copy link
Member

JOJ0 commented Mar 1, 2022

Unfortunately I'm not able to do that.

But you can!

Yes I can but you can too :-) For such a small fix you could even edit this directly on github without any git CLI knowledge necessary at all (if that was the reason holding you back)! Did you know that?

@jordanbs
Copy link
Author

jordanbs commented Mar 1, 2022

I'm sorry, I'm legally not allowed to contribute to open source :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants