Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version error in the release workflow #5274

Merged
merged 6 commits into from
Jun 9, 2024

Conversation

Serene-Arc
Copy link
Contributor

This hopefully fixes the issue we experienced where the version was not incremented before the package was built. This should make sure that it works correctly.

@Serene-Arc Serene-Arc requested a review from snejus June 1, 2024 04:49
@Serene-Arc
Copy link
Contributor Author

Hey @snejus if you wanna push your markdown code to this branch, we can get it all working and fixed in one PR.

@snejus
Copy link
Member

snejus commented Jun 1, 2024

Cool, will do! To be clear, do you mean the code that converts rst changelog to md?

@Serene-Arc
Copy link
Contributor Author

Yes, the part I removed. I removed a bunch of stuff but if you actually have it working, then we might as well add it back in. It'll be a bit of a pain to make it so it's output as part of the action (which is why I removed it in the first place) but it should be manageable.

@snejus
Copy link
Member

snejus commented Jun 3, 2024

@Serene-Arc thanks for the confirmation - this makes sense. I don't think this should pose too many issues - let me get on it.

@snejus
Copy link
Member

snejus commented Jun 4, 2024

@Serene-Arc See the commits I have just pushed

@snejus
Copy link
Member

snejus commented Jun 4, 2024

See the resulting changelog for 2.0.0 below

With this release, beets now requires Python 3.7 or later (it removes support for Python 3.6).

Major new features

New features

Bug fixes

For plugin developers

  • Allow reuse of some parts of beets' testing components. This may ease the work for externally developed plugins or related software (e.g. the beets plugin for Mopidy), if they need to create an in-memory instance of a beets music library for their tests.
  • beets now explicitly prevents multiple plugins to define replacement functions for the same field. When previously defining template_fields for the same field in two plugins, the last loaded plugin would silently overwrite the function defined by the other plugin. Now, beets will raise an exception when this happens. 🐛 (beetsplug: only one plugin can set template_fields per field #5002)

For packagers

Other changes

Serene-Arc and others added 4 commits June 5, 2024 19:12
Black requires that there be double quotes instead of single
Looking at the logs, it's using the ref before the one that increments
the version in the previous action in the workflow. This code is from
actions/checkout#439 (comment)
and supposedly fixes this by making it pull specifically from master,
rather than the ref that the workflow was called on.
@snejus
Copy link
Member

snejus commented Jun 5, 2024

I rebased the PR off the most recent master @Serene-Arc .

Additionally, update the 'in progress' header in the changelog: instead
of using a specific version number, simply say 'Unreleased' since we do
not know in advance what version will the changes be eventually
released.

This also simplifies latest changelog retrieval.
@Serene-Arc
Copy link
Contributor Author

Cool, thanks. I've reviewed the changes and it seems good to me. I'll merge and we can make another release whenever.

@Serene-Arc Serene-Arc merged commit b53908f into beetbox:master Jun 9, 2024
9 checks passed
@Serene-Arc Serene-Arc deleted the release_workflow_fix branch June 9, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants