-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should drop Python 3.7 #5222
Comments
@sampsyo @Serene-Arc @snejus @arsaboo @JOJ0 just pinging a bunch of recently active people here. |
I have no objections, seems like a good idea to me |
Agreed... no objections. |
Because I was looking at the corresponding issue, I think we should hold off on this change until October, because Python 3.8 reaches EOL then. If we change it now, we'll have to raise it again a month or two later anyway. Might be easier on everyone if we just upgrade to 3.9 all at once. |
@Serene-Arc #5266 requires 3.8 as a minimum, since we are using tox version 4 which requires 3.8 as a minimum, and without it dependency resolution fails. Dropping 3.7 and then 3.8 later as separate steps may be a less risky option. If I imagine myself as a Python 3.7 user, I'd prefer upgrading step by step rather than having to jump two Python versions. It's also slightly easier for us developers: for example, |
Good points, let's do that then. We should start planning for 3.9 pretty soon though. |
## Description Fixes #5222. Drop Python 3.7. `pyupgrade` is responsible for most of the changes in the code. I undid some of the bits it attempted to update that aren't strictly necessary: 1. Converting `List/Dict/Tuple` -> `list/dict/tuple` in modules that have `from __future__ import annotations` import. This should be done in a separate PR, and for all modules 2. Converting some `.format(` calls to f-strings. It didn't do it consistently, and it should also be done in a separate PR, I believe. Python upgrade unblocks several other PRs, for example #5266 and #5248.
In #5215, our minimum supported Python version came up: We currently state 3.7, but that's been EOL since June 2023. I think we should drop that and allow 3.8+ features. Any objections?
The text was updated successfully, but these errors were encountered: