deezer: Tolerate missing fields when searching for singletons #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
reviewed
Dec 12, 2021
ybnd
force-pushed
the
pr_deezer_tolerate_missing_fields
branch
from
c0eb7e2
to
82a2a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4116
When searching for singletons, Deezer doesn't return
track_positionordisk_numberinformation.Made these fields optional, confirmed that candidates load as expected without these fields.
To Do
docs/to describe it.)docs/changelog.rstnear the top of the document.)Tests. (Encouraged but not strictly required.)AFAIK thedeezerplugin is not tested yet, seems out of scope to write tests from scratch for this PR