Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importadded plugin with reflink #4390

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

toyo-chi
Copy link
Contributor

@toyo-chi toyo-chi commented Jun 28, 2022

Description

Fixes #4389
It seems to me that this issue may be fixed in a similar way to previously fixed importadded issue #1107 and hardlink option #2445.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@sampsyo
Copy link
Member

sampsyo commented Jun 29, 2022

Ah, good detective work! Thank you for the quick fix! Would you mind adding a very brief changelog entry describing the fix here?

@toyo-chi
Copy link
Contributor Author

What other dark secrets are hidden in the beets code history? See in the next epi

...OK, changelog entry is done. My English is pretty bad... but I really tried!

@sampsyo
Copy link
Member

sampsyo commented Jun 29, 2022

Looks pretty good to me!! 🎉 Thank you for your help with this!!!

@sampsyo sampsyo merged commit 5dcce07 into beetbox:master Jun 29, 2022
@toyo-chi toyo-chi deleted the importadded_reflink_fix branch June 30, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import error with reflink enabled and importadded plugin
2 participants