Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaygain: Fix error handling for parallel runs #4506

Merged
merged 3 commits into from
Oct 1, 2022
Merged

replaygain: Fix error handling for parallel runs #4506

merged 3 commits into from
Oct 1, 2022

Commits on Oct 1, 2022

  1. replaygain: Fix error handling for parallel runs 

    The parallelism strategy in #3478, in retrospect, used a pretty funky
way to deal with exceptions in the asynchronous work---since
`apply_async` has an `error_callback` parameter that's meant for exactly
this. The problem is that the wrapped function would correctly log the
exception *and then return `None`*, confusing any downstream code.
Instead of just adding `None`-awareness to the callback, let's just
avoid running the callback altogether in the case of an error.
    @sampsyo
    sampsyo committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    9803939 View commit details
    Browse the repository at this point in the history

  2. Changelog for #4506

    @sampsyo
    sampsyo committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    eaabf29 View commit details
    Browse the repository at this point in the history

  3. Add logging for command output on errors

    @sampsyo
    sampsyo committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    675dd7b View commit details
    Browse the repository at this point in the history