Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforced utf-8 encoding on imported files #4730

Merged
merged 6 commits into from
Apr 7, 2023
Merged

Conversation

elyang0214
Copy link
Contributor

Description

Fixes #4693.
To address the bug outlined in issue #4693, we added a utf-8 encoding argument to the import_files function in the commands.py file.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started! Here are a couple of small suggestions about the documentation.

docs/reference/cli.rst Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me! Many thanks!!

@sampsyo sampsyo merged commit 6955c53 into beetbox:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import log should probably force a UTF-8 encoding
2 participants