4326 scrub should not restore on import if "write" is disabled

[fracai]

Description

Fixes #4326.

scrub.py:import_task_files now passes ui.should_write() to _scrub_item to control restoring tags.
I also added a few tests to test_importer.py.

To Do

• Documentation. (fixes discrepancy between documentation and behavior)
• Changelog.
• Tests.

[fracai]

just realized that the tests are checking the database tags, not the file tags. I'll have to fix those later today

[fracai]

just realized that the tests are checking the database tags, not the file tags. I'll have to fix those later today

and those should now be working properly

[sampsyo]

This overall looks like it's on the right track, but FWIW it looks like some tests are still failing.

[fracai]

This overall looks like it's on the right track, but FWIW it looks like some tests are still failing.

Turns out if you call load_plugins(…) in test setup you also need to call unload_plugins() in test teardown. Who knew?

[sampsyo]

Awesome; this is just great!! Thanks for the tidy work here.