Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setup.py packaging by Poetry #5266

Merged
merged 29 commits into from
Jun 12, 2024
Merged

Replace setup.py packaging by Poetry #5266

merged 29 commits into from
Jun 12, 2024

Commits on Jun 10, 2024

  1. Configure pyproject.toml

    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    614ba1d View commit details
    Browse the repository at this point in the history
  2. Use poetry in workflows

    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    90263a9 View commit details
    Browse the repository at this point in the history
  3. Update workflows

    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e30ee3f View commit details
    Browse the repository at this point in the history
  4. Update all docs with Poetry

    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    7bbd215 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1aad6e0 View commit details
    Browse the repository at this point in the history
  6. Introduce Poe the Poet task runner and define tasks.

    This makes it easier for people to interact with the project in
    a unified manner.
    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    347911c View commit details
    Browse the repository at this point in the history
  7. Remove tox

    Unfortunately tox does not play very nicely with Poetry. Tox was mostly
    useful since it managed virtual environments, however now this is done
    by Poetry.
    
    Thus we do not anymore need it since we can run our commands using
    `poetry run`. I have extended the internal helper tool 'project' with
    those commands that have previously been run using tox.
    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    bfd9753 View commit details
    Browse the repository at this point in the history
  8. Update workflows

    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4a8e6e9 View commit details
    Browse the repository at this point in the history
  9. Lint only changed files

    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    5ccc69d View commit details
    Browse the repository at this point in the history
  10. Simplify logic ci.yaml

    Changed the logic so that it isn't testing repeatedly for the correct matrix version, and since we're using poetry instead of pipx, changed the action
    Serene-Arc authored and snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4494acd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6b2ec01 View commit details
    Browse the repository at this point in the history
  12. Rename action

    Serene-Arc authored and snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    b57c0dd View commit details
    Browse the repository at this point in the history
  13. Only format correct directories

    Serene-Arc authored and snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4f566f1 View commit details
    Browse the repository at this point in the history
  14. Add poethepoet to dependencies for devs

    Serene-Arc authored and snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    35533b3 View commit details
    Browse the repository at this point in the history
  15. Use poetry prefix

    Serene-Arc authored and snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4d5b821 View commit details
    Browse the repository at this point in the history
  16. Use poetry action instead of pipx

    Serene-Arc authored and snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f3c9f03 View commit details
    Browse the repository at this point in the history
  17. Simplify workflow

    Serene-Arc authored and snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    6d7a6df View commit details
    Browse the repository at this point in the history
  18. Partially revert "Simplify logic ci.yaml"

    This reverts commit 913f856.
    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    b00a83c View commit details
    Browse the repository at this point in the history
  19. Revert "Only format correct directories"

    This reverts commit c3b6f07.
    
    This commit hardcoded the paths that `isort` and `black` checks. This
    means that the `check-format` job will act on the entire codebase
    instead of only changed files. We need to define a `path` argument with
    a default value in order to achieve the above.
    
    Regarding "." vs "beets beetsplug test", the intention behind using "."
    was to also check python files like `docs/conf.py` and
    `extra/release.py` which I presume we would also want to format
    properly.
    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    627c069 View commit details
    Browse the repository at this point in the history
  20. Revert "Add poethepoet to dependencies for devs"

    This reverts commit fc373f5.
    
    See CONTRIBUTING.rst which has tools setup guidelines for users. They
    are expected to install both poetry and poethepoet globally in their
    system.
    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f3df90c View commit details
    Browse the repository at this point in the history
  21. Revert "Use poetry prefix"

    This reverts commit af996f4.
    
    Since `poethepoet` is installed globally in the workflows, running it
    does not require `poetry run` suffix. This is actually one of the
    reasons why it's preferable to have this tool installed globally.
    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    fee65ba View commit details
    Browse the repository at this point in the history
  22. Revert "Simplify workflow"

    This reverts commit 4550d39.
    
    I love this attempt to DRY-up the linting workflow! I remember back in
    the day also initially assuming that this is how the jobs work. However,
    I had to meet the harsh reality of each job needing to be set up from
    zero. :(
    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    17ec590 View commit details
    Browse the repository at this point in the history
  23. Revert "Use poetry action instead of pipx"

    This reverts commit 5526bd3.
    
    Poetry must be installed before `setup-python` action, weirdly. And we
    need to install poethepoet globally too!
    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    6763722 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    4752fb0 View commit details
    Browse the repository at this point in the history
  25. Update dependencies

    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    6d3b76d View commit details
    Browse the repository at this point in the history
  26. Document the changes

    snejus committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a4ed6ab View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Configuration menu
    Copy the full SHA
    50cf70e View commit details
    Browse the repository at this point in the history
  2. Format docs/conf.py

    snejus committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c2a13ee View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Fix sphinx docs linting

    snejus committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    0507f6f View commit details
    Browse the repository at this point in the history