-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace setup.py packaging by Poetry #5266
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 614ba1d - Browse repository at this point
Copy the full SHA 614ba1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90263a9 - Browse repository at this point
Copy the full SHA 90263a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e30ee3f - Browse repository at this point
Copy the full SHA e30ee3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bbd215 - Browse repository at this point
Copy the full SHA 7bbd215View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aad6e0 - Browse repository at this point
Copy the full SHA 1aad6e0View commit details -
Introduce Poe the Poet task runner and define tasks.
This makes it easier for people to interact with the project in a unified manner.
Configuration menu - View commit details
-
Copy full SHA for 347911c - Browse repository at this point
Copy the full SHA 347911cView commit details -
Unfortunately tox does not play very nicely with Poetry. Tox was mostly useful since it managed virtual environments, however now this is done by Poetry. Thus we do not anymore need it since we can run our commands using `poetry run`. I have extended the internal helper tool 'project' with those commands that have previously been run using tox.
Configuration menu - View commit details
-
Copy full SHA for bfd9753 - Browse repository at this point
Copy the full SHA bfd9753View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a8e6e9 - Browse repository at this point
Copy the full SHA 4a8e6e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ccc69d - Browse repository at this point
Copy the full SHA 5ccc69dView commit details -
Changed the logic so that it isn't testing repeatedly for the correct matrix version, and since we're using poetry instead of pipx, changed the action
Configuration menu - View commit details
-
Copy full SHA for 4494acd - Browse repository at this point
Copy the full SHA 4494acdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b2ec01 - Browse repository at this point
Copy the full SHA 6b2ec01View commit details -
Configuration menu - View commit details
-
Copy full SHA for b57c0dd - Browse repository at this point
Copy the full SHA b57c0ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f566f1 - Browse repository at this point
Copy the full SHA 4f566f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35533b3 - Browse repository at this point
Copy the full SHA 35533b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d5b821 - Browse repository at this point
Copy the full SHA 4d5b821View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3c9f03 - Browse repository at this point
Copy the full SHA f3c9f03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d7a6df - Browse repository at this point
Copy the full SHA 6d7a6dfView commit details -
Partially revert "Simplify logic ci.yaml"
This reverts commit 913f856.
Configuration menu - View commit details
-
Copy full SHA for b00a83c - Browse repository at this point
Copy the full SHA b00a83cView commit details -
Revert "Only format correct directories"
This reverts commit c3b6f07. This commit hardcoded the paths that `isort` and `black` checks. This means that the `check-format` job will act on the entire codebase instead of only changed files. We need to define a `path` argument with a default value in order to achieve the above. Regarding "." vs "beets beetsplug test", the intention behind using "." was to also check python files like `docs/conf.py` and `extra/release.py` which I presume we would also want to format properly.
Configuration menu - View commit details
-
Copy full SHA for 627c069 - Browse repository at this point
Copy the full SHA 627c069View commit details -
Revert "Add poethepoet to dependencies for devs"
This reverts commit fc373f5. See CONTRIBUTING.rst which has tools setup guidelines for users. They are expected to install both poetry and poethepoet globally in their system.
Configuration menu - View commit details
-
Copy full SHA for f3df90c - Browse repository at this point
Copy the full SHA f3df90cView commit details -
This reverts commit af996f4. Since `poethepoet` is installed globally in the workflows, running it does not require `poetry run` suffix. This is actually one of the reasons why it's preferable to have this tool installed globally.
Configuration menu - View commit details
-
Copy full SHA for fee65ba - Browse repository at this point
Copy the full SHA fee65baView commit details -
This reverts commit 4550d39. I love this attempt to DRY-up the linting workflow! I remember back in the day also initially assuming that this is how the jobs work. However, I had to meet the harsh reality of each job needing to be set up from zero. :(
Configuration menu - View commit details
-
Copy full SHA for 17ec590 - Browse repository at this point
Copy the full SHA 17ec590View commit details -
Revert "Use poetry action instead of pipx"
This reverts commit 5526bd3. Poetry must be installed before `setup-python` action, weirdly. And we need to install poethepoet globally too!
Configuration menu - View commit details
-
Copy full SHA for 6763722 - Browse repository at this point
Copy the full SHA 6763722View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4752fb0 - Browse repository at this point
Copy the full SHA 4752fb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d3b76d - Browse repository at this point
Copy the full SHA 6d3b76dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4ed6ab - Browse repository at this point
Copy the full SHA a4ed6abView commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 50cf70e - Browse repository at this point
Copy the full SHA 50cf70eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2a13ee - Browse repository at this point
Copy the full SHA c2a13eeView commit details
Commits on Jun 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0507f6f - Browse repository at this point
Copy the full SHA 0507f6fView commit details