Re-imports: preserve added dates and flexible attributes #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When re-importing, `item.added` and `album.added` will be preserved if their path match what they are replacing.
Move the reimport and replaced item logic into separate methods: * ImportTask.record_replaced() * ImportTask.remove_replaced() * ImportTask.reimport_metadata()
Conflicts: beets/importer.py
Unicode strings, .format() templating, and displayable_path sanitation. Really makes me wish for automatic formatting stuff in the logger...
This was erroneous before: it always said "N of N" due to the presence of empty lists.
Currently, these just return no results. (For our testing purposes, the matches we get from the ordinary metadata search suffice just fine.)
[ci skip]
|
Thanks for adding the tests. I can't see that the conflict resolution have broken anything, everything looks good! :-) |
|
Thanks for checking! Merging now. ✨ |
sampsyo
added a commit
that referenced
this pull request
Sep 29, 2014
Re-imports: preserve added dates and flexible attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the reincarnation of #950 by the amazing @silb (c.f. #925, #911).
Re-imports now preserve albums' and items' added dates and flexible attributes, as it should be. There are also now tests covering the re-import logic, including this new behavior.