feat: add default tls option logic to controller #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ingress tls options to configmap refactor, allow auto vs static modes adapt helm chart to changes renamt to secret name add validations fix helm validation parametrize tls mode in quick installation script test installation with ingress validate ingress/tls behaviour add ingress test action default installtion tls mode should be none use my image make kind ingress compatible need an example where ingress is enabled polish test code rename example with ingress fix template condition commit before we delete it delete env vars for local testing make sure configmap is refreshed add gh action for all three modes for 1-26 we need the kind cluster config too fix lynt issues fix lint Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
|
/run-e2e |
|
/run-e2e |
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
|
/run-e2e |
|
@yetone any update on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ingress tls options to configmap
refactor, allow auto vs static modes
adapt helm chart to changes
renamt to secret name
add validations
fix helm validation
parametrize tls mode in quick installation script
test installation with ingress
validate ingress/tls behaviour
add ingress test action
default installtion tls mode should be none
use my image
make kind ingress compatible
need an example where ingress is enabled
polish test code
rename example with ingress
fix template condition
commit before we delete it
delete env vars for local testing
make sure configmap is refreshed
add gh action for all three modes
for 1-26 we need the kind cluster config too
fix lynt issues
fix lint
Signed-off-by: David van der Spek vanderspek.david@gmail.com