New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing separator for Roles & RoleBindings #126

Merged

yetone merged 2 commits into bentoml:main from hjilke:main

Oct 9, 2023

Contributor

hjilke commented Oct 9, 2023

What:
When adding multiple namespaces for bentoDeploymentNamespaces

Example:
bentoDeploymentNamespaces: ['yatai', 'deployments']

Then:
There seems to be missing separators in the helm manifest resulting in missing deployed resources. Here the fix.

henrik added 2 commits

October 9, 2023 17:04


          fix: missing separators for roles & bindings in charts

d05f9cf


          refactor: add missing line

4dba13c

yetone merged commit f2dadd7 into bentoml:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet