chore(gov): Convert uint8[] to bytes for Message value bz
#1211
Conversation
WalkthroughThe changes primarily involve the replacement of Changes
TipsChat with CodeRabbit Bot (
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
=======================================
Coverage 51.32% 51.32%
=======================================
Files 82 82
Lines 4828 4828
=======================================
Hits 2478 2478
Misses 2177 2177
Partials 173 173
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Files selected for processing (28)
- contracts/bindings/cosmos/lib/cosmos_types.abigen.go (4 hunks)
- contracts/bindings/cosmos/precompile/governance/i_governance_module.abigen.go (7 hunks)
- contracts/bindings/testing/consume_gas.abigen.go (1 hunks)
- contracts/bindings/testing/distribution_testing_helper.abigen.go (1 hunks)
- contracts/bindings/testing/governance/governance_wrapper.abigen.go (6 hunks)
- contracts/bindings/testing/liquid_staking.abigen.go (1 hunks)
- contracts/bindings/testing/precompile_constructor.abigen.go (1 hunks)
- contracts/bindings/testing/solmate_erc20.abigen.go (1 hunks)
- contracts/src/cosmos/CosmosTypes.sol (1 hunks)
- cosmos/config/mocks/app_options.go (1 hunks)
- cosmos/lib/conversions.go (1 hunks)
- cosmos/txpool/mocks/geth_tx_pool.go (1 hunks)
- cosmos/txpool/mocks/lifecycle.go (1 hunks)
- cosmos/txpool/mocks/sdk_tx.go (1 hunks)
- cosmos/txpool/mocks/subscription.go (1 hunks)
- cosmos/txpool/mocks/tx_broadcaster.go (1 hunks)
- cosmos/txpool/mocks/tx_serializer.go (1 hunks)
- cosmos/txpool/mocks/tx_sub_provider.go (1 hunks)
- eth/core/state/journal/mocks/accesslist.go (1 hunks)
- eth/core/state/journal/mocks/log.go (1 hunks)
- eth/core/state/journal/mocks/refund.go (1 hunks)
- eth/core/state/journal/mocks/self_destruct_state_plugin.go (1 hunks)
- eth/core/state/journal/mocks/self_destructs.go (1 hunks)
- eth/core/state/journal/mocks/transient_storage.go (1 hunks)
- eth/core/state/mocks/plugin.go (1 hunks)
- eth/core/state/mocks/polar_state_db.go (1 hunks)
- eth/core/state/mocks/precompile_plugin.go (1 hunks)
- eth/core/types/transaction.rlpgen.go (1 hunks)
Files not summarized due to errors (2)
- contracts/bindings/testing/governance/governance_wrapper.abigen.go: Error: Message exceeds token limit
- contracts/bindings/testing/liquid_staking.abigen.go: Error: Message exceeds token limit
Files skipped from review due to trivial changes (24)
- contracts/bindings/cosmos/precompile/governance/i_governance_module.abigen.go
- contracts/bindings/testing/consume_gas.abigen.go
- contracts/bindings/testing/precompile_constructor.abigen.go
- contracts/bindings/testing/solmate_erc20.abigen.go
- contracts/src/cosmos/CosmosTypes.sol
- cosmos/config/mocks/app_options.go
- cosmos/txpool/mocks/geth_tx_pool.go
- cosmos/txpool/mocks/lifecycle.go
- cosmos/txpool/mocks/sdk_tx.go
- cosmos/txpool/mocks/subscription.go
- cosmos/txpool/mocks/tx_broadcaster.go
- cosmos/txpool/mocks/tx_serializer.go
- cosmos/txpool/mocks/tx_sub_provider.go
- eth/core/state/journal/mocks/accesslist.go
- eth/core/state/journal/mocks/log.go
- eth/core/state/journal/mocks/refund.go
- eth/core/state/journal/mocks/self_destruct_state_plugin.go
- eth/core/state/journal/mocks/self_destructs.go
- eth/core/state/journal/mocks/transient_storage.go
- eth/core/state/mocks/plugin.go
- eth/core/state/mocks/polar_state_db.go
- eth/core/state/mocks/precompile_plugin.go
- eth/core/types/transaction.rlpgen.go
- contracts/bindings/testing/liquid_staking.abigen.go (diff too large)
Additional comments (Suppressed): 7
contracts/bindings/testing/distribution_testing_helper.abigen.go (1)
- 34-36: The ABI and bytecode of the
DistributionWrappercontract have been updated. Ensure that these changes are compatible with the rest of the system and that all dependencies have been updated accordingly. Also, verify that the new ABI and bytecode have been thoroughly tested.contracts/bindings/testing/governance/governance_wrapper.abigen.go (1)
- 32-36: The type of
Valuefield inCosmosCodecAnystruct has been changed from[]uint8to[]byte. Ensure that this change doesn't break any existing functionality whereCosmosCodecAnyis used. Also, verify that the new type[]byteis handled correctly in all the places where this struct is used.cosmos/lib/conversions.go (1)
- 362-362: The
Valuefield in theCosmosCodecAnystruct has been changed from[]uint8to[]byte. This change is reflected in thedecodeProposalMessagesfunction. Ensure that this change does not affect the rest of the codebase where this function is used or where theCosmosCodecAnystruct is expected to have aValuefield of type[]uint8.contracts/bindings/cosmos/lib/cosmos_types.abigen.go (4)
35-35: The data type of the
Valuefield in theCosmosCodecAnystruct has been changed from[]uint8to[]byte. Ensure that this change is compatible with the rest of your codebase and that all instances ofCosmosCodecAnyhave been updated accordingly.61-63: The ABI and bytecode in the
CosmosTypesMetaDatahave been updated. TheinternalTypeof thevaluefield in theCodecAnyfunction has been changed fromuint8[]tobytes. Ensure that these changes are reflected in your smart contract on the Ethereum network.232-237: The
CodecAnyfunction has been updated to reflect the changes in theCosmosCodecAnystruct and theCosmosTypesMetaData. Ensure that all calls to this function have been updated to match the new signature.247-259: The
CodecAnyfunction in theCosmosTypesSessionandCosmosTypesCallerSessionstructs has been updated to reflect the changes in theCosmosCodecAnystruct and theCosmosTypesMetaData. Ensure that all calls to this function have been updated to match the new signature.
Summary by CodeRabbit
CosmosCodecAnyandCosmosCoinstructs, replacing[]uint8with[]bytefor theValuefield to align with functional usage in Cosmos SDK.GovernanceModulecontract, replacinguint8[]withbytesin thegetProposalandgetProposalsfunctions.decodeProposalMessagesfunction to handle different types using reflection.rlpgentool intransaction.rlpgen.go.