[pull] 2.0-dev from kata-containers:2.0-dev #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Use conditional compilation (#[cfg]) to change mount and umount behaviours at compilation time. For example, such functions will just return `Ok(())` when the unit tests are being compiled, otherwise real mount and umount operations are performed. Signed-off-by: Julio Montes <julio.montes@intel.com>
Add tempfile crate as depedency, it will be used in the following commits to create temporary directories for unit testing. Signed-off-by: Julio Montes <julio.montes@intel.com>
Don't use unwrap in `init_rootfs` instead return an Error, this way we can write unit tests that don't panic. Signed-off-by: Julio Montes <julio.montes@intel.com>
Add a unit test for `init_rootfs` increasing the code coverage of mount.rs from 0% to 44%. Signed-off-by: Julio Montes <julio.montes@intel.com>
Add a unit test for `mount_cgroups` increasing the code coverage of mount.rs from 44% to 52% Signed-off-by: Julio Montes <julio.montes@intel.com>
Use conditional compilation (#[cfg]) to change pivot_root behaviour at compilation time. For example, such function will just return `Ok(())` when the unit tests are being compiled, otherwise real pivot_root operation is performed. Signed-off-by: Julio Montes <julio.montes@intel.com>
Add unit test for pivot_rootfs increasing the code coverage of mount.rs Signed-off-by: Julio Montes <julio.montes@intel.com>
Use conditional compilation (#[cfg]) to change chroot behaviour at compilation time. For example, such function will just return `Ok(())` when the unit tests are being compiled, otherwise real chroot operation is performed. Signed-off-by: Julio Montes <julio.montes@intel.com>
Increase code coverage of mount.rs Signed-off-by: Julio Montes <julio.montes@intel.com>
remove `makedev` function, use `nix`'s implementation instead Signed-off-by: Julio Montes <julio.montes@intel.com>
Add unit tests for finish_root, read_only_path and mknod_dev increasing code coverage of mount.rs fixes #284 Signed-off-by: Julio Montes <julio.montes@intel.com>
RUST_BACKTRACE=1 will help us a lot to debug unit tests when a test is failing Signed-off-by: Julio Montes <julio.montes@intel.com>
It should be set by default for Kata containers working with containerd. Fixes: #775 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
agent: Unit tests for rustjail/mount.rs
how-to: add privileged_without_host_devices to containerd guide
bergwolf
pushed a commit
that referenced
this pull request
Oct 26, 2022
This kata-ctl argument returns the latest stable Kata release by hitting github.com. Adds check-version unit tests. Fixes: #11 Signed-off-by: David Esparza <david.esparza.borquez@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )