Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text and Corner radius bugs #24

Closed
oney opened this issue Feb 6, 2021 · 4 comments
Closed

Text and Corner radius bugs #24

oney opened this issue Feb 6, 2021 · 4 comments

Comments

@oney
Copy link

oney commented Feb 6, 2021 •
edited
Loading

1

Text elements under auto layout parent with "Fill container" width doesn't have width: 100% in generated codes.

2

Corner radius in Figma doesn't produce border-radius: in generated codes.

3

Text's color generates something like<p class="Location" style="font-size: 11.50px; text: rgba(37.78, 188.06, 13.32, 1);">Text</p>. It should be color: rgba(37.78, 188.06, 13.32, 1);

4

In auto layout, the bottom empty spacing div's height of a Text should = parent's spacing + Text's height - Text's font size to be more accurate.
@bernaferrari
Copy link
Owner

Awesome feedback, I'll fix them!

@bernaferrari
Copy link
Owner

Ok, I have fixed 1, 2 and 3 already (landing in Figma soon, as soon as I fix the others).

I don't understand 4. Is this difference what you mean?
image

@oney
Copy link
Author

oney commented Feb 6, 2021

Never mind for 4.
When line height is auto in Figma, the generated CSS won't have line-height. This makes inconsistency in look.
So inconsistency can be fixed by manually setting the line height to be a value in Figma.

@bernaferrari
Copy link
Owner

bernaferrari commented Feb 7, 2021 •
edited
Loading

I fixed it, but only for HTML. HTML supports height 100%.

TigerStar429 pushed a commit to TigerStar429/Figma_Code that referenced this issue May 30, 2023
Add code formatting for HTML and Tailwind!
6490b3f 
Fix border-radius missing in HTML.

Fix missing border-radius in Vector.

Add rose color to Vectors (which are unsupported).

Fix Text when parent is set to fill (all frameworks).

Fix color attribute in HTML's Text being misnamed.

Fix textHeight in HTML.

Fix justify layout in HTML.

Change: when single item layout is set to justify, center it.

Close bernaferrari/FigmaToCode#24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bernaferrari @oney