-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Tailwind implementation #110
Merged
bernaferrari
merged 8 commits into
bernaferrari:main
from
davestewart:feat/tailwind-config
Jul 12, 2024
Merged
Simplify Tailwind implementation #110
bernaferrari
merged 8 commits into
bernaferrari:main
from
davestewart:feat/tailwind-config
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dave Stewart <dev@davestewart.co.uk>
* Modify Tailwind color functions to support Figma variables * Refactor function to arrow function * Fix fill opacity code * Add new Tailwind preferences * Prefer Tailwind color when color matches exactly * Update UI with shorter labels and tooltips --------- Co-authored-by: Dave Stewart <dev@davestewart.co.uk>
Refactoring: * Reorganise all config to separate file * Simplify Tailwind code Color: * Update Tailwind Colors list to clarify conversion * Update PluginUI to show actual used colors
@bernaferrari – this is now ready to go:
It's up to you what you name this PR as; could be:
|
Either way the name is fine. Thanks for all the help! |
Great! OK, now to move on with the flex wrap stuff |
Looks like I introduced a bug with the de-duping of colors for non-Tailwind platforms: Let me take a look now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the Tailwind config, code location and implementation.
It aims to:
Code
tailwindConfig.ts
(perhaps a stepping stone to custom config, too)conversionTables.ts
retrieveColors.ts
totailwindColor.ts
(simplifying the code and bringing it in line with other platforms)Main UI
scss
formatPlugin UI
[#hex]
is shown for non-rounded colors (rather than just#hex
) as this is the actual "class name"