Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite: modular approach #7

Merged
merged 20 commits into from
Mar 5, 2019
Merged

Rewrite: modular approach #7

merged 20 commits into from
Mar 5, 2019

Conversation

ghostbar
Copy link
Contributor

@ghostbar ghostbar commented Mar 4, 2019 •
edited by sadasant
Loading

Fixes #3

@ghostbar ghostbar self-assigned this Mar 4, 2019
@ghostbar ghostbar requested a review from sadasant March 4, 2019 03:45
sadasant
sadasant reviewed Mar 4, 2019
View reviewed changes
gh/content.go Show resolved Hide resolved
sadasant
sadasant requested changes Mar 4, 2019
View reviewed changes
gh/comment.go Show resolved Hide resolved
@sadasant
Copy link
Member

sadasant commented Mar 4, 2019

This is the problem that CircleCI is having: golang/go#27056
I'm also having this myself. On it...

@sadasant
module files and CI bash scripts
cfe1a45 
- deleted the handler_test for now
- missing modules
- CI bash scripts

Merged and squashed from: #8
@sadasant sadasant force-pushed the feat/rewrite branch 3 times, most recently from be85698 to 4426a1c Compare March 4, 2019 06:05
@sadasant
Copy link
Member

sadasant commented Mar 4, 2019 •
edited
Loading

IMPORTANT: This doesn't work on Zeit.co. They use an older version:
https://github.com/zeit/now-builders/blob/master/packages/now-go/go-helpers.js#L93
and they disable GO111MODULE by default due to having GO111MODULE=auto.

I can manually set GO111MODULE to on, but 1.11 doesn't know how to mix go.mod with dependencies in GOPATH, see: https://golang.org/doc/go1.12#modules

... the go command now supports module-aware operations outside of a module directory, provided that those operations do not need to resolve import paths relative to the current directory or explicitly edit the go.mod file. ...

I did the silliest of pull requests to zeit/now-builders just to bring awareness to the issue: https://github.com/zeit/now-builders/pull/247

@ghostbar
Copy link
Contributor Author

ghostbar commented Mar 4, 2019

Going back to single-module repo for Zeit :-)

@sadasant
zeit is back
74190cd 
Zeit.co needs a main package with the Handler exposed, so I moved
handler/handler.go to index.go :) now we know.
@sadasant sadasant self-requested a review March 5, 2019 04:43
sadasant
sadasant approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

betacar
betacar approved these changes Mar 5, 2019
View reviewed changes
Copy link

@betacar betacar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sadasant sadasant merged commit 58b3294 into master Mar 5, 2019
@sadasant sadasant deleted the feat/rewrite branch March 5, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betacar betacar betacar approved these changes

@sadasant sadasant sadasant approved these changes

@stefanmaric stefanmaric Awaiting requested review from stefanmaric

Assignees

@ghostbar ghostbar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghostbar @sadasant @betacar