Replaced the 'datetime.utcnow()' method with 'datetime.now(timezone.utc)' #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Guri-X thanks for the PR! It seems like You've missed a spot where we parse the timestamp from a previously recorded interaction. That parsing needs to be timezone aware for this change to pass tests |
|
@sigmavirus24 Thanks for pointing out the issue. I will review the code again and will push the required changes. |
…times' in the BetamaxAdapter class
|
@sigmavirus24 I fixed the issue. It should be able to clear all tests now. |
sigmavirus24
reviewed
May 6, 2024
sigmavirus24
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #209