default balance algo determine whether to pick loser_picks or split_noobs depending on circumstances #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR creates a new balance algo called "default" which becomes the default. It will call
If team size != 2 then call loser_picks
Otherwise if at least one newish player call split_noobs
Otherwise call loser_picks
Finally complaints over years where people say that new players are overrated can be put to rest. I have been observing multiple noob lobby games with split_noobs and am happy with the results (other than the chev icon being wrong for an unknown reason sometimes).
In SPADS we would later need to make a change to make loser_picks not voteable, but instead make default voteable instead.
Testing
You can go to website and pick default from the balance dropdown when inspecting a match