Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default balance algo determine whether to pick loser_picks or split_noobs depending on circumstances #429

Merged

Conversation

jauggy
Copy link
Member

@jauggy jauggy commented Aug 26, 2024

Feature

This PR creates a new balance algo called "default" which becomes the default. It will call

If team size != 2 then call loser_picks
Otherwise if at least one newish player call split_noobs
Otherwise call loser_picks

Finally complaints over years where people say that new players are overrated can be put to rest. I have been observing multiple noob lobby games with split_noobs and am happy with the results (other than the chev icon being wrong for an unknown reason sometimes).

In SPADS we would later need to make a change to make loser_picks not voteable, but instead make default voteable instead.

Testing

You can go to website and pick default from the balance dropdown when inspecting a match

@jauggy jauggy marked this pull request as ready for review August 26, 2024 00:31
@jauggy jauggy marked this pull request as draft August 26, 2024 00:33
@jauggy jauggy marked this pull request as ready for review August 26, 2024 00:41
lib/teiserver/battle/balance/default_balance.ex Outdated Show resolved Hide resolved
lib/teiserver/battle/balance/default_balance.ex Outdated Show resolved Hide resolved
lib/teiserver/battle/balance/default_balance.ex Outdated Show resolved Hide resolved
lib/teiserver/battle/balance/default_balance.ex Outdated Show resolved Hide resolved
lib/teiserver/battle/libs/balance_lib.ex Outdated Show resolved Hide resolved
@jauggy
Copy link
Member Author

jauggy commented Aug 27, 2024

Updated based on feedback.

@L-e-x-o-n as requested the default balance algorithm is now in admin config. Have set to "loser_picks" but can change to "default".

@jauggy jauggy force-pushed the jauggy/call-split-noobs-default branch from be864e1 to 9b5e99f Compare August 27, 2024 04:12
@L-e-x-o-n L-e-x-o-n merged commit 000f1ad into beyond-all-reason:master Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants