Skip to content
This repository has been archived by the owner on Apr 30, 2019. It is now read-only.

Netflix PIP #7

Merged
merged 36 commits into from
Oct 12, 2016
Merged

Netflix PIP #7

merged 36 commits into from
Oct 12, 2016

Conversation

JoeKuhns
Copy link
Contributor

Not sure if I am doing the correctly, I have never actually done a pull on someone else Git. But, here are modifications to include it working with Netflix. I was unable to get the icon in the control bar, in the mean time can you merge this in so we can get a signed one? I only have a corporate apple account and don't think I should be signing this with that one.

@JoeKuhns JoeKuhns mentioned this pull request Sep 24, 2016
@bfmatei bfmatei self-assigned this Oct 12, 2016
@bfmatei bfmatei changed the base branch from master to dev October 12, 2016 15:25
@bfmatei
Copy link
Owner

bfmatei commented Oct 12, 2016

Hello,

First of all please accept my apologises. I was extremely busy with my day-to-day work and couldn't pay attention to this.

I created a dev branch, updated the pull request to point to the dev branch and i will take care of the merging now.

I will let the project as it is, with your contributions but I will continue to host the extension on my GitHub page. I will also try to publish the plugin on the Safari Extensions page. Fingers crossed :)

Thank you, again, for your work.

If you have any other comments, feel free to write them down.

Regards,
Bogdan

@bfmatei bfmatei merged commit d4ef0d5 into bfmatei:dev Oct 12, 2016
@JoeKuhns
Copy link
Contributor Author

Sooo, I am actually all ready to submit to apple. So what do you want to do? I was going to add a couple of more sites, but with updates working I can do that at any time. Let me know your thoughts.

p.s. I like my name better :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants