Use commitlint for better commit quality. #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit looks good. But not sure why the CI failed though. @angular/compiler-cli@5.1.0 requires typescript@'>=2.4.2 <2.5.0' but 2.5.3 was found instead.May be - we need to bring typescript to 2.4.2 ? ( Independent of this issue - but tracked separately in #97 though ). |
|
Ok - seems like the forceful fail test of foo prefix is the reason. Good to go.. |
bfwg
force-pushed
the
setup-commitlint
branch
from
acf4443
to
b05546f
Compare
|
Thanks for reviewing @akkumar |
|
Also added issue #98 docs to note the list of types available for commit for future reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @akkumar , it commitlint would be good to have.
Closes #95