Add initialize_list overload to DataTable::addSample #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3864c31.
bgrimstad
approved these changes
Jun 22, 2018
There was a problem hiding this comment.
Accepting these changes.
Note that: 1) we want merge requests to be made to the develop branch or branched derived from develop, 2) compiler warnings have been removed in the develop branch by updating Eigen, and 3) there is an indentation error in datatable.h.
Thank you for your contribution to SPLINTER.
|
Thanks for your review. |
|
In addition, could I modify these changes again, and commit them to develop branch? @bgrimstad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.