#161 - Modify isValid() to discriminate against improper formats used for colors #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey.
Like so many others have said already--thanks for providing this awesome library!
This is being posted in regard to issue #161. The patch applied discriminates against color inputs that either use extra commas, or otherwise choose numbers from outside the valid range (eg, 0-360, 0-100%, 0-100%, 0-1).
That said, with your help and any recommendations upon review, I was hoping to submit this particular pull request so that the issue above can be addressed.
Thanks for your time.