WIP - add test for functional creation #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functional creation probably only doesn't work because typescript says its not callable. I don't usually test against the dist directory, but you can. would need to change the order on travis to build first https://github.com/bgrins/TinyColor/blob/v2/.travis.yml#L6-L8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the functional creation does actually work in node as well, it just doesn't in the test when we import from
import TinyColor from '../src/public_api';because I guess that's not compiling down to es2015, or something.This isn't landable since it will break tests if
npm run builddidn't happen first. But I'm now wondering though.. should we be testing against dist/ instead of src/? I could see a gap where all tests pass against src/ but there was a bug with the build / packaging itself and we shipped out a broken dist/? Or is that a narrow enough gap that it's not worth worrying about. @scttcper any thoughts? I'm not sure what's normally done with TS projects.